jquery - AngularJS - Does scrolling to an element belong in a directive? -


i'm aware dom manipulation belongs in directives rather controllers, i'm hung on whether scrolling element (with jquery's scrolltop) considered dom manipulation and/or should moved directive.

my page dynamically generated (using grails) , small bootstrap dropdown placed on corner of page facilitate scrolling places within lengthy document:

<a ng-click="scrollto('question${ subquestion.id}')">

the ${} replaced number when sent client.

my scrollto function within controller rather simple , works:

$scope.scrollto = function(id) {     $('html, body').animate({         scrolltop: $('#' + id).offset().top - 50     }, 1000); };

i'm using ui-router , using $uiviewscroll scroll element; seemed more in line angular way need 50px offset because of navigation bar , prefer animation (both don't seem option $uiviewscroll).

questions:

  • does scrolling element have digest consequences true dom manipulation?
  • is scrolling element outside of directive bad practice? if so, why?

  • scrolling runs outside of normal digest cycle, see thread how can hide element when page scrolled?
  • i bad practice since includes references elements in dom, that's me... :-) perhaps can make testing controller bit harder since need handle $.

Comments

Post a Comment

Popular posts from this blog

sublimetext3 - what keyboard shortcut is to comment/uncomment for this script tag in sublime -

Image
i have script tag in code, keyboard shortcut comment/uncomment script tag in sublime. after selecting script open , close tag. <script src="http://code.jquery.com/jquery-latest.min.js" type="text/javascript"> </script> i pressing ctrl + shift + / , getting this /*<script src="http://code.jquery.com/jquery-latest.min.js" type="text/javascript"> </script>*/ also pressed ctrl + / , got this // <script src="http://code.jquery.com/jquery-latest.min.js" type="text/javascript"> // </script> instead of <!-- <script src="http://code.jquery.com/jquery-latest.min.js" type="text/javascript"> </script> --> script open , close tag in 2 lines not in 1 line , not have spaces too. for mac,high light lines want comment. hold 'command , / ' commented. for windows: high line or select lines ,then hold ctrl + / if not work: ...
Read more

post - imageshack API cURL -

i credentials correct. when send image through form this:(action="http://api.imageshack.com/v2/images/"). working fine when tried send $ch = curl_init($url); failed. code: enter code here <form action="" method="post" enctype="multipart/form-data"> select image upload: <input type="file" name="file" id="file" multiple> <input type="text" name="auth_token" id="auth_token" value="xxxxxxxxxxxxxxxx"> <input type="text" name="api_key" id="api_key" value="xxxxxxxxxxxxxxx"> <input type="submit" value="upload image" > </form> $url = ' http://api.imageshack.com/v2/images/ '; $temp = $_files["file"]['tmp_name']; echo $temp."<br>" ; $ch = curl_init($url); curl_setopt($ch, curlopt_post, true); curl...
Read more

dataset - MPAndroidchart returning no chart Data available -

i having problems mpandroidchart. adding temperature , humidity data chart, displays "no chart data available". here can see bug is? super grateful! //create data //set size of data int size = list.size(); if (size > 24){ size = 24;} //create lists form temp , hum arraylist<entry> temps = new arraylist<entry>(); arraylist<entry> hums = new arraylist<entry>(); //fill list temp values (int = 0; < size; i++){ entry value = new entry(math.round(list.get(list.size()-size + i).temp), (size-i)); temps.add(value); } //fill list hum values (int = 0; < size; i++){ entry value = new entry(math.round(list.get(list.size()-size + i).hum), (size-i)); hums.add(value); } ...
Read more