Java number guessing game weird output - 


public class test {     public static void main(string[] args) {         system.out.println("welcome siddharth's number guessing game. \nthink of number between 1 , 100 , press 1 continue");         scanner x= new scanner(system.in);         if (x.nextint()==1)         {         int high=100;            int low=0;         int guess=(high+low)/2;         system.out.println("is number "+ guess+"? press 0 if yes, press 1 if number higher number or press 2 if number lower number!");         scanner y= new scanner(system.in);         int ans=y.nextint();            while(ans!=0)            {                if (ans==1)                {                    low=ans;                     guess=(high+low)/2;                     system.out.println("is number "+ guess+"? press 0 if yes, press 1 if number higher number or press 2 if number lower number!");                     scanner y1= new scanner(system.in);                     ans=y1.nextint();                }                else if (ans==2)                {                    high=ans;                     guess=(high+low)/2;                     system.out.println("is number "+ guess+"? press 0 if yes, press 1 if number higher number or press 2 if number lower number!");                     scanner y2= new scanner(system.in);                     ans=y2.nextint();                }             }            system.out.println("the number thought is"+guess+"! playing!");         }         else         {             system.out.println("no problem. restart program , press 1 when ready!");         }     }  }

i have thought number 22, , entered 2 when asked me if number 50. straight away went 1. whatever enter, showing 1 output instead of going 50, 25, 12 etc. have done same in python , c , work perfectly.

ok, so, first problem assign ans high , low instead of guess.

then, if can give advices:

  1. don't create new scanner everytime. instead, use same x scanner
  2. don't put common actions inside each if/else block. instead, put common operations outside.
  3. you can give instructions (1 higher, etc) once, , ask "is number xx? (0:yes, 1:higher, 2:lower)". more readable.

here improved version, sure can make better:

public static void main( string[] args ){     system.out.println( "welcome siddharth's number guessing game. \nthink of number between 1 , 100 , "             + "press 1 continue" );      scanner x = new scanner( system.in );      if( x.nextint() == 1 ){          int high = 100;         int low = 0;         int guess = ( high + low ) / 2;          system.out.println( "is number " + guess + "? press 0 if yes, press 1 if number higher " +                 "this number or press 2 if number lower number!" );           while( true ){              int ans = x.nextint();             if( ans == 0 ){                 break;              }else if( ans == 1 ){                 low = guess;              }else if( ans == 2 ){                 high = guess;              }              guess = ( high + low ) / 2;             system.out.printf( "is number %d ? (0: yes, 1: higher, 2:lower) ", guess );         }          system.out.println( "the number thought of " + guess + "! playing!" );      }else{         system.out.println( "no problem. restart program , press 1 when ready!" );     } }

Comments

Post a Comment

Popular posts from this blog

sublimetext3 - what keyboard shortcut is to comment/uncomment for this script tag in sublime -

Image
i have script tag in code, keyboard shortcut comment/uncomment script tag in sublime. after selecting script open , close tag. <script src="http://code.jquery.com/jquery-latest.min.js" type="text/javascript"> </script> i pressing ctrl + shift + / , getting this /*<script src="http://code.jquery.com/jquery-latest.min.js" type="text/javascript"> </script>*/ also pressed ctrl + / , got this // <script src="http://code.jquery.com/jquery-latest.min.js" type="text/javascript"> // </script> instead of <!-- <script src="http://code.jquery.com/jquery-latest.min.js" type="text/javascript"> </script> --> script open , close tag in 2 lines not in 1 line , not have spaces too. for mac,high light lines want comment. hold 'command , / ' commented. for windows: high line or select lines ,then hold ctrl + / if not work: ...
Read more

post - imageshack API cURL -

i credentials correct. when send image through form this:(action="http://api.imageshack.com/v2/images/"). working fine when tried send $ch = curl_init($url); failed. code: enter code here <form action="" method="post" enctype="multipart/form-data"> select image upload: <input type="file" name="file" id="file" multiple> <input type="text" name="auth_token" id="auth_token" value="xxxxxxxxxxxxxxxx"> <input type="text" name="api_key" id="api_key" value="xxxxxxxxxxxxxxx"> <input type="submit" value="upload image" > </form> $url = ' http://api.imageshack.com/v2/images/ '; $temp = $_files["file"]['tmp_name']; echo $temp."<br>" ; $ch = curl_init($url); curl_setopt($ch, curlopt_post, true); curl...
Read more

dataset - MPAndroidchart returning no chart Data available -

i having problems mpandroidchart. adding temperature , humidity data chart, displays "no chart data available". here can see bug is? super grateful! //create data //set size of data int size = list.size(); if (size > 24){ size = 24;} //create lists form temp , hum arraylist<entry> temps = new arraylist<entry>(); arraylist<entry> hums = new arraylist<entry>(); //fill list temp values (int = 0; < size; i++){ entry value = new entry(math.round(list.get(list.size()-size + i).temp), (size-i)); temps.add(value); } //fill list hum values (int = 0; < size; i++){ entry value = new entry(math.round(list.get(list.size()-size + i).hum), (size-i)); hums.add(value); } ...
Read more